Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component consolidation #1346

Draft
wants to merge 247 commits into
base: dev
Choose a base branch
from
Draft

Component consolidation #1346

wants to merge 247 commits into from

Conversation

davidornelas11
Copy link
Contributor

Description

This is the main feature branch for the component consolidation effort

Links

FOR APPROVERS

@davidornelas11 davidornelas11 requested review from a team as code owners August 26, 2024 23:23
@davidornelas11 davidornelas11 marked this pull request as draft August 26, 2024 23:33
Copy link
Member

@mlsamuelson mlsamuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues to resolve before merge:

  • unspalsh images need to be replaced in Image, Heroes, Card and wherever they occur.
  • carousel based stories need to force React version. When Bootstrap version displays, they are not interactive.
  • Modal and Tabbed Panels stories throw error on Docs page.
  • Static site footer image
  • table fixed story needs to force React version. Bootstrap version is not interactive. Also errors on Docs page.

@mlsamuelson
Copy link
Member

Also need to ensure that component-header-footer works in WS2 before we merge this. cc @davidornelas11

@mlsamuelson
Copy link
Member

UDS-1912 to update use of unity-react-core internally is still pending, too. cc @scott-williams-az

fix(unity-react-core): fix broken images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants